Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(players)!: extended player roles #953

Merged
merged 2 commits into from
Mar 29, 2021
Merged

feat(players)!: extended player roles #953

merged 2 commits into from
Mar 29, 2021

Conversation

garrappachc
Copy link
Member

  • replace Player.role with Player.roles
  • Player.roles is an array of PlayerRole enum

@garrappachc garrappachc added the enhancement New feature or request label Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021 •
edited
Loading

Codecov Report

Merging #953 (b4625d4) into master (927c2a9) will increase coverage by 0.02%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
+ Coverage   94.25%   94.28%   +0.02%     
==========================================
  Files         158      159       +1     
  Lines        3101     3117      +16     
  Branches      291      292       +1     
==========================================
+ Hits         2923     2939      +16     
  Misses        177      177              
  Partials        1        1
Impacted Files Coverage Δ
...ns/discord/services/admin-notifications.service.ts 92.55% <75.00%> (+0.16%) ⬆️
src/auth/guards/role.guard.ts 100.00% <100.00%> (ø)
...figuration/controllers/configuration.controller.ts 100.00% <100.00%> (ø)
src/documents/controllers/documents.controller.ts 100.00% <100.00%> (ø)
.../controllers/game-server-diagnostics.controller.ts 100.00% <100.00%> (ø)
...ame-servers/controllers/game-servers.controller.ts 100.00% <100.00%> (ø)
src/games/controllers/games.controller.ts 100.00% <100.00%> (ø)
src/players/controllers/players.controller.ts 79.16% <100.00%> (+0.29%) ⬆️
src/players/models/player-role.ts 100.00% <100.00%> (ø)
src/players/models/player.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927c2a9...b4625d4. Read the comment docs.

@garrappachc garrappachc merged commit 7577a1e into tf2pickup-org:master Mar 29, 2021
@garrappachc garrappachc deleted the extended-player-roles branch March 29, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garrappachc